Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse filename from response header #399

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: parse filename from response header #399

merged 1 commit into from
Jun 30, 2023

Conversation

wongearl
Copy link
Contributor

fix: parse filename from resp header

LinuxSuRen
LinuxSuRen requested changes Jun 30, 2023
View reviewed changes
Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes need to be removed. See also the following syntax:

image

More details from https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition

@LinuxSuRen LinuxSuRen added the bug Something isn't working label Jun 30, 2023
@LinuxSuRen LinuxSuRen changed the title fix: parse filename from resp header fix: parse filename from response header Jun 30, 2023
@wongearl
Copy link
Contributor Author

The quotes need to be removed. See also the following syntax:

image

More details from https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition

ok, i have fixed it

@LinuxSuRen
Copy link
Owner

See the lint errors:

Error: pkg/net/http.go:334:1: exported function ParseSuggestedFilename should have comment or be unexported

@LinuxSuRen LinuxSuRen merged commit fda35f4 into LinuxSuRen:master Jun 30, 2023
@wongearl wongearl deleted the fix/filename branch July 5, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wongearl @LinuxSuRen